Wireshark-commits: [Wireshark-commits] master 0cd1a85: Require BER dissector (OID) registration to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Nov 2015 19:21:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cd1a8506425fa379c88df941e3039ce9a1164d4
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0cd1a85 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Require BER dissector (OID) registration to be "new style".
    
    Both old and new style API existed, just remove the "old" one.
    
    Change-Id: If725e778a0ecad5a431d634ed5c4856b4a281013
    Reviewed-on: https://code.wireshark.org/review/12107
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  992a7ee   asn2wrs.py: always use relative paths
    adds  0cd1a85   Require BER dissector (OID) registration to be "new style".


Summary of changes:
 asn1/cdt/cdt.cnf                       |    2 +-
 asn1/ftam/packet-ftam-template.c       |   14 +--
 asn1/gsm_map/packet-gsm_map-template.c |  166 ++++++++++++++++----------------
 asn1/p1/packet-p1-template.c           |    7 +-
 asn1/p1/packet-p1-template.h           |    2 +-
 asn1/pkcs1/packet-pkcs1-template.c     |   26 ++---
 asn1/pkcs12/packet-pkcs12-template.c   |    6 +-
 asn1/pres/packet-pres-template.c       |    2 +-
 asn1/snmp/packet-snmp-template.c       |    9 +-
 asn1/t124/packet-t124-template.c       |   14 +--
 asn1/x509af/packet-x509af-template.c   |   42 ++++----
 asn1/x509ce/packet-x509ce-template.c   |   16 +--
 debian/libwireshark0.symbols           |    2 -
 epan/dissectors/packet-ber.c           |   34 ++-----
 epan/dissectors/packet-ber.h           |    6 +-
 epan/dissectors/packet-cdt.c           |    2 +-
 epan/dissectors/packet-ftam.c          |   18 ++--
 epan/dissectors/packet-gsm_map.c       |  166 ++++++++++++++++----------------
 epan/dissectors/packet-p1.c            |   15 +--
 epan/dissectors/packet-p1.h            |    2 +-
 epan/dissectors/packet-pkcs1.c         |   26 ++---
 epan/dissectors/packet-pkcs12.c        |   12 ++-
 epan/dissectors/packet-pres.c          |    2 +-
 epan/dissectors/packet-snmp.c          |   13 +--
 epan/dissectors/packet-t124.c          |   18 ++--
 epan/dissectors/packet-x509af.c        |   42 ++++----
 epan/dissectors/packet-x509ce.c        |   16 +--
 27 files changed, 327 insertions(+), 353 deletions(-)