Wireshark-commits: [Wireshark-commits] master-2.0 d93918f: Fix memory leak in capture_get_if_capabi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Nov 2015 13:14:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d93918f2b856b8048eb3a402c893529f155c57fa
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d93918f by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):

    Fix memory leak in capture_get_if_capabilities
    
    Valgrind reports memory leaks like these:
    154 bytes in 10 blocks are possibly lost in loss record 8,660 of 11,855
      at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      by 0xBD9EA38: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
      by 0xBDB3358: g_strndup (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
      by 0xBDB49AD: g_strsplit (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
      by 0x502291: capture_get_if_capabilities (capture_ifinfo.c:269)
      by 0x50A4CC: scan_local_interfaces (iface_lists.c:186)
      by 0x4C4BBD: refresh_local_interface_lists (capture_dlg.c:6117)
      by 0x504EC8: iface_mon_handler2 (iface_monitor.c:113)
      by 0xC9ADF1D: ??? (in /lib/libnl-3.so.200.3.0)
      by 0xC56DF19: ??? (in /usr/lib/libnl-route-3.so.200.3.0)
      by 0xC9ABE5E: nl_cache_parse (in /lib/libnl-3.so.200.3.0)
      by 0xC9AF5CA: nl_msg_parse (in /lib/libnl-3.so.200.3.0)
    
    Under certain conditions raw_list variable was not freed properly.
    
    Change-Id: Ibbaf0d67d983ee6912cfc9dc1a3169bc773b03c9
    Reviewed-on: https://code.wireshark.org/review/12112
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 479ab3bcdc8d79b27bfc99fcde073457f72126ac)
    Reviewed-on: https://code.wireshark.org/review/12139
    

Actions performed:

    from  7ea63cf   Fix buffer overrun in zlib decompression
    adds  d93918f   Fix memory leak in capture_get_if_capabilities


Summary of changes:
 capchild/capture_ifinfo.c |    2 ++
 1 file changed, 2 insertions(+)