Wireshark-commits: [Wireshark-commits] master-1.12 2c59970: Check *how many* fields sscanf() found.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Nov 2015 05:49:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c5997060c1cc91dc3ba964d4494751b50f25470
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

2c59970 by Guy Harris (guy@xxxxxxxxxxxx):

    Check *how many* fields sscanf() found.
    
    In the code that parses a GeneralizedTime field, don't assume that all
    fields were found; check the return value from sscanf().
    
    This should clean up a fuzz failure on the 2.0 buildbot:
    
    https://buildbot.wireshark.org/wireshark-2.0/builders/Fuzz%20Test/builds/13/steps/valgrind-wireshark/logs/stdio
    
    Change-Id: I431d7ed69ac1697bd42c22a37ca1451cfc85c94e
    Reviewed-on: https://code.wireshark.org/review/12083
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 921bb07115fbffc081ec56a5022b4a9d58db6d39)
    Reviewed-on: https://code.wireshark.org/review/12085
    

Actions performed:

    from  c6efada   HiSLIP: remove a DISSECTOR_ASSERT
    adds  2c59970   Check *how many* fields sscanf() found.


Summary of changes:
 epan/dissectors/packet-ber.c |  113 ++++++++++++++++++++++++++++++------------
 1 file changed, 82 insertions(+), 31 deletions(-)