Wireshark-commits: [Wireshark-commits] master-2.0 1b50a32: epan: Free pointers to deallocated memor
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Nov 2015 06:11:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b50a326fb5b8126bf701f4208d80648809612fe
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1b50a32 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Free pointers to deallocated memory
    
    When redissecting packets we call epan_free() which deallocates
    wmem_file_scope memory.  Such memory may be used in proto_data for
    the currently selected packet (cf->edt) and leaves pointers to
    deallocated memory (cf->edt->pi.fd->pfd).  Free them after
    epan_free() to avoid unintended usage in packet_list_clear().
    
    Bug: 11740
    Change-Id: Ia3bc54f3f34e644a98b8a7eb1addd19b8aeeaab9
    Reviewed-on: https://code.wireshark.org/review/11996
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 391f11a7ec16045ed5909d617edcaada1f8f9afc)
    Reviewed-on: https://code.wireshark.org/review/12053
    

Actions performed:

    from  d4f355c   merge: fix parameter 'in_files/in_count_files' not found in the function declaration [-Wdocumentation]
    adds  1b50a32   epan: Free pointers to deallocated memory


Summary of changes:
 file.c |    6 ++++++
 1 file changed, 6 insertions(+)