Wireshark-commits: [Wireshark-commits] master 91f4e3b: Have a separate dissector for pcap/pcapng-fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Nov 2015 02:53:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=91f4e3b73d6929591d6b0790c7e1a4c1810f045d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

91f4e3b by Guy Harris (guy@xxxxxxxxxxxx):

    Have a separate dissector for pcap/pcapng-format packet data.
    
    Put that dissector into its own file, and get handles for it from the
    pcap and pcapng file dissectors.  Put the value_string of pcap/pcapng
    LINKTYPE_ values there, and have the pcap and pcapng file dissectors
    import it.
    
    Expand that table to include all LINKTYPE_ values in the current
    libpcap.
    
    Change-Id: I9397035efa5711e8a18a26e056d3b54494fd3148
    Reviewed-on: https://code.wireshark.org/review/12000
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fef4714   File-format: Add ISO_14443 linktype for PCAP/PCAPNG
    adds  91f4e3b   Have a separate dissector for pcap/pcapng-format packet data.


Summary of changes:
 epan/CMakeLists.txt                                |    1 +
 epan/dissectors/Makefile.common                    |    2 +
 epan/dissectors/file-pcap.c                        |  240 +------------
 epan/dissectors/file-pcapng.c                      |  154 +-------
 epan/dissectors/packet-pcap_pktdata.c              |  372 ++++++++++++++++++++
 .../{packet-btatt.h => packet-pcap_pktdata.h}      |   30 +-
 6 files changed, 398 insertions(+), 401 deletions(-)
 create mode 100644 epan/dissectors/packet-pcap_pktdata.c
 copy epan/dissectors/{packet-btatt.h => packet-pcap_pktdata.h} (67%)