Wireshark-commits: [Wireshark-commits] master b1a8a0d: MPTCP: Use endianness macros directly instea
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Nov 2015 00:25:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1a8a0da52ff03262c8e86088b52d2fd0137d10f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b1a8a0d by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    MPTCP: Use endianness macros directly instead of creating new tvbuff
    
    tvb_new_real_data() will leak memory.
    
    Also fix endianness because use of GUINT64_SWAP_LE_BE() assumes
    platform is little endian.
    
    Change-Id: Ic90d568e585e08674638519c11bd5deb4358bff1
    Reviewed-on: https://code.wireshark.org/review/11540
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f38bd00   Commiting CISCO ERSPAN3 Marker dissector for pushing to upstream
    adds  b1a8a0d   MPTCP: Use endianness macros directly instead of creating new tvbuff


Summary of changes:
 epan/dissectors/packet-tcp.c |   45 +++++++++++++++---------------------------
 1 file changed, 16 insertions(+), 29 deletions(-)