Wireshark-commits: [Wireshark-commits] master 6893348: Qt: Fix some flow graph issues.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Nov 2015 17:46:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=689334876ec12d5a037e5bb1fad3e0d023890049
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6893348 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix some flow graph issues.
    
    Make fillDiagram() a slot and call it after the dialog is visible.
    
    Use the activated() signals instead of currentIndexChanged() for our
    comboboxes. The former is only emitted as a result of user interaction
    and the latter is always emitted when the value changed. This was a
    problem for flowComboBox since initializing its value resulted an extra
    call to fillDiagram().
    
    Add a progress frame.
    
    Change-Id: I17bcf5c990363ee758be9e3a0604dde34fc34f2d
    Ping-Bug: 11710
    Reviewed-on: https://code.wireshark.org/review/11897
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  44ca31d   [iso14443] do a more precise check for uid-related commands
    adds  6893348   Qt: Fix some flow graph issues.


Summary of changes:
 ui/qt/sequence_dialog.cpp |   22 +++++++++-------------
 ui/qt/sequence_dialog.h   |    9 +++++----
 2 files changed, 14 insertions(+), 17 deletions(-)