Wireshark-commits: [Wireshark-commits] master 0a0a811: catapult: fix sscanf buffer overflow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Nov 2015 21:10:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a0a811ea6124c8fa3a006032493eb44083848c4
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0a0a811 by Evan Huus (eapache@xxxxxxxxx):

    catapult: fix sscanf buffer overflow
    
    Caught by cppcheck. The buffer is 9+1 characters, which means we should specify
    9, not 10 to the scanf string since the count does not include the
    null-terminator.
    
    Change-Id: I0aae8cce337055b304efa9399cd5d8059928d2d8
    Reviewed-on: https://code.wireshark.org/review/11887
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  4224aab   Qt: do not clear display filter when merging files
    adds  0a0a811   catapult: fix sscanf buffer overflow


Summary of changes:
 wiretap/catapult_dct2000.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)