Wireshark-commits: [Wireshark-commits] master-2.0 03a3896: Don't include wireshark-gtk.desktop in R
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Nov 2015 14:31:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03a3896ece78a5801924d702a47ae4823c6af3eb
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

03a3896 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't include wireshark-gtk.desktop in RPMs.
    
    The RPMs use 'alternatives' to determine which GUI is used so it doesn't make
    sense to have 2 desktop entries: one for 'wireshark' (Qt or Gtk GUI, depending on
    configuration) and one for 'wireshark-gtk' (the Gtk GUI).
    
    (Maybe it makes sense to just not use 'alternatives' and allow the user to pick
    which GUI is used via the menu system.  But then if they wanted to run the Gtk+
    GUI from the command line they'd need to remember to run 'wireshark-gtk' even
    if that's the only GUI installed...)
    
    Change-Id: I9d3fe13bb01eab87caad4ad21c6571ef6288b110
    Reviewed-on: https://code.wireshark.org/review/11780
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit fc51af45e65b534fa52c5519e23a7250ada195be)
    Reviewed-on: https://code.wireshark.org/review/11873
    

Actions performed:

    from  52b40aa   Qt: add a reference counter to sequence analysis info
    adds  03a3896   Don't include wireshark-gtk.desktop in RPMs.


Summary of changes:
 packaging/rpm/SPECS/wireshark.spec.in |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)