Wireshark-commits: [Wireshark-commits] master 2773596: Qt: add a reference counter to sequence anal
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Nov 2015 09:57:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2773596970c362a6d81c7e44311781590074c43f
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2773596 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: add a reference counter to sequence analysis info
    
    Increment the reference counter each time a flow sequence window is opened.
    Free seq_analysis_info_t structure once the last flow sequence / VoIP calls / SIP flow window is closed.
    
    Bug: 11712
    Change-Id: I20fcb922b0516417d4bd74cdf75475dcb31f8b90
    Reviewed-on: https://code.wireshark.org/review/11851
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  442314e   Revert "Override optimization and other flags for make based generators."
    adds  2773596   Qt: add a reference counter to sequence analysis info


Summary of changes:
 ui/gtk/voip_calls_dlg.c     |    5 +++
 ui/qt/sequence_dialog.cpp   |   82 ++++++++++++++++++++++++-------------------
 ui/qt/sequence_dialog.h     |   17 +++++++--
 ui/qt/voip_calls_dialog.cpp |    5 +--
 ui/qt/voip_calls_dialog.h   |    3 ++
 ui/voip_calls.c             |    7 ----
 6 files changed, 72 insertions(+), 47 deletions(-)