Wireshark-commits: [Wireshark-commits] master-2.0 0554c2f: Qt: Coloring Rules dialog fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 Nov 2015 01:49:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0554c2f61698de06ca15ffe497c8890f4a9db6c3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0554c2f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Coloring Rules dialog fixups.
    
    Insert new rules at the top. This matches the GTK+ UI behavior. Recolor
    the packet list when we press "OK". Add a "to do" item about setting the
    filter column width.
    
    Change-Id: I2a9e58fe8642a89f12e1c34622b96613f3ec4c05
    Reviewed-on: https://code.wireshark.org/review/11781
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit f5d7548497eb63ebe010e5199038ef2300bf95aa)
    Reviewed-on: https://code.wireshark.org/review/11791
    

Actions performed:

    from  5cf57a8   Qt: fix UI artifacts seen in UAT window on Linux or OSX
    adds  0554c2f   Qt: Coloring Rules dialog fixups.


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp |   19 ++++++++++++++-----
 ui/qt/coloring_rules_dialog.h   |    2 +-
 ui/qt/main_window_slots.cpp     |    8 ++++++--
 ui/qt/packet_list.h             |    2 +-
 4 files changed, 22 insertions(+), 9 deletions(-)