Wireshark-commits: [Wireshark-commits] master-2.0 1c1a5c2: Qt: fix cursor position when editing col
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Nov 2015 20:43:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c1a5c2e5c95d21d7ce4798cb954c107273e9fde
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

1c1a5c2 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix cursor position when editing coloring rules names or filters
    
    A call to setText will set the cursor to the end of the box.
    As far as I can tell, this call is useless so let's remove it.
    
    Bug: 11689
    Change-Id: I40aee48745a9107331a017070a715a075106974a
    Reviewed-on: https://code.wireshark.org/review/11727
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit ca2ecc124144dfd7273213232b585808dc8a06a5)
    Reviewed-on: https://code.wireshark.org/review/11746
    

Actions performed:

    from  8050a32   Put wtap_dump_open() right before wtap_dump_open_ng().
    adds  1c1a5c2   Qt: fix cursor position when editing coloring rules names or filters


Summary of changes:
 ui/qt/coloring_rules_dialog.cpp |   11 -----------
 ui/qt/coloring_rules_dialog.h   |    1 -
 2 files changed, 12 deletions(-)