Wireshark-commits: [Wireshark-commits] master c2afc9e: Change prototype of callbacks passed to wmem
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Nov 2015 00:22:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c2afc9edec79b247d02f42ba3c7cad2bc24b9f91
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c2afc9e by Matthieu Coudron (mattator@xxxxxxxxx):

    Change prototype of callbacks passed to wmem_tree_foreach so that they
    accept the node key as a first parameter.
    
    wmem_tree accepts all sort of keys (strings, integers, soon ranges),
    thus it is of interest for various purposes (testing, greedy search) to
    know the key of the node.
    
    Change-Id: Ie748b917bef91f0b1ba8cce15bd1b471922641dc
    Reviewed-on: https://code.wireshark.org/review/11683
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b9b74fc   ISI: fix code will never be executed [-Wunreachable-code]
    adds  c2afc9e   Change prototype of callbacks passed to wmem_tree_foreach so that they accept the node key as a first parameter.


Summary of changes:
 epan/dissectors/packet-aeron.c |    2 +-
 epan/dissectors/packet-lbtrm.c |    2 +-
 epan/dissectors/packet-lbtru.c |    2 +-
 epan/prefs.c                   |   10 +++++-----
 epan/wmem/wmem_test.c          |    2 +-
 epan/wmem/wmem_tree.c          |    2 +-
 epan/wmem/wmem_tree.h          |    2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)