Wireshark-commits: [Wireshark-commits] master-2.0 3a962d4: Call wtap_dump_open_check() in wtap_dump
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Nov 2015 11:30:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a962d4d3e61fb9eeec0aa58135dd51ca4a1b1da
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

3a962d4 by Guy Harris (guy@xxxxxxxxxxxx):

    Call wtap_dump_open_check() in wtap_dump_init_dumper().
    
    The callers of wtap_dump_init_dumper() always call
    wtap_dump_open_check() first, with the same arguments in all cases; pull
    the latter call into wtap_dump_init_dumper() itself.
    
    Change-Id: I2b44dc3a018745e175b5c74ff1a346749fec2b71
    Reviewed-on: https://code.wireshark.org/review/11681
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 6ae50ebf28cd40d5c7e1ef5493c22e896564c4f2)
    Reviewed-on: https://code.wireshark.org/review/11682
    

Actions performed:

    from  9d48e02   Add a comment for is_stdout.
    adds  3a962d4   Call wtap_dump_open_check() in wtap_dump_init_dumper().


Summary of changes:
 wiretap/file_access.c |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)