Wireshark-commits: [Wireshark-commits] master-2.0 6b5837c: GIOP dissector: Replies are not correctl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Nov 2015 09:03:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b5837c222fd43fb6c43b6aa2510f4ca3ee78828
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6b5837c by AndyL (andy.ling@xxxxxxxxx):

    GIOP dissector: Replies are not correctly associated with requests
    
    Added IP address and port number to the comp_req_list_entry so
    get_mfn_from_fn_and_reqid can check for matching IP and port number
    when searching for the reply to a request.
    
    Change-Id: Iad00bca5c1104cf8c335001f84264fe55d2e45fc
    Reviewed-on: https://code.wireshark.org/review/11599
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 0a993232bfbe182015f4ebb02d7af790f4be45bb)
    Reviewed-on: https://code.wireshark.org/review/11672
    

Actions performed:

    from  dd736b9   ZCL (zbee): Use hf_zbee_zcl_attr_uint40 for ZBEE_ZCL_40_BIT_UINT
    adds  6b5837c   GIOP dissector: Replies are not correctly associated with requests


Summary of changes:
 epan/dissectors/packet-giop.c |   18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)