Wireshark-commits: [Wireshark-commits] master-2.0 68d5d1d: RPC: call REPORT_DISSECTOR_BUG() rather
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Nov 2015 08:57:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68d5d1d963357a75bbcb9e11e67d8295577c033c
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

68d5d1d by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    RPC: call REPORT_DISSECTOR_BUG() rather than abort().
    
    Checking WIRESHARK_ABORT_ON_DISSECTOR_BUG here looks somewhat redundant but it's not:
    it's needed to prevent REPORT_DISSECTOR_BUG() from throwing an exception when
    we're not dissecting (when nobody's going to catch the exception).
    
    Change-Id: I4dfc484bdf13bca236bfff1388d4399e26880ad7
    Reviewed-on: https://code.wireshark.org/review/11272
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 3e5b2537f7fdff838f611f779fff526cdda1a2a3)
    Reviewed-on: https://code.wireshark.org/review/11670
    

Actions performed:

    from  ce173bb   file.c: do not try to close a file descriptor that was previously already closed
    adds  68d5d1d   RPC: call REPORT_DISSECTOR_BUG() rather than abort().


Summary of changes:
 epan/dissectors/packet-rpc.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)