Wireshark-commits: [Wireshark-commits] master caa1e87: Use ws_{read, write, fdopen, close}.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 Nov 2015 10:32:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=caa1e87410fb74606f2ec91b5fd1b897053149bf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

caa1e87 by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_{read,write,fdopen,close}.
    
    Be more consistent about using the ws_ routines, as we suggest in
    README.developer.
    
    In C++ on UN*X, define ws_close as ::close rather than close, so that it
    works even in classes with methods or members named "close".
    
    Change-Id: Ide2652229e6b6b4624cbddae0e909a4ea1efa591
    Reviewed-on: https://code.wireshark.org/review/11637
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  11bdada   Update to reflect current reality.
    adds  caa1e87   Use ws_{read,write,fdopen,close}.


Summary of changes:
 dumpcap.c                   |    4 ++--
 rawshark.c                  |    6 +++---
 ui/cli/tap-follow.c         |    2 +-
 ui/gtk/follow_tcp.c         |    2 +-
 ui/gtk/iax2_analysis.c      |   14 +++++++-------
 ui/qt/main_window_slots.cpp |   10 +++++-----
 ui/win32/file_dlg_win32.c   |    6 +++---
 wiretap/file_access.c       |    4 ++--
 wiretap/file_wrappers.c     |    8 ++++----
 wsutil/file_util.h          |    7 +++++++
 10 files changed, 35 insertions(+), 28 deletions(-)