Wireshark-commits: [Wireshark-commits] master 35a1383: Major Re-factoring of the dissector and some
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Nov 2015 07:52:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35a13838146ac5d83b57435ff34f2960ea911248
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

35a1383 by cbontje (cbontje@xxxxxxxxx):

    Major Re-factoring of the dissector and some new features.
    
    A change-list is as follows:
    - Removed un-necessary dissector revision updates from the file header since GIT tracks these nicely.
    - Added proper size detection of Modbus RTU messages (including exception responses), when dealing with partial TCP segment reassembly.
    - Moved the 'register' decode preferences to the Modbus dissector as TCP vs. RTU granularity isn't needed in this case.
    - Obsoleted un-unused 'address type format' user preferences
    - Cleaned up dissect_modbus_data to remove proto_tree_set_text instances.
    - For decoded register tree objects, use register 'address' instead of 'value' for the filter field to provide a more useful filter.
    - Added in conversation support, to attempt to track responses back to matching requests.
    - Use conversation support to attempt to populate proper register address offsets in the response messages.  Currently each request is saved and each response looks for the last prior request that matches the function code.
    - Re-factored Modbus dissector to split apart request vs. response decoding.  This has led to cleaner code paths, but some duplication where replies and requests are identical format.
    
    Change-Id: I0c86ae85b8ae4cc59b037e5f68f408833205fadd
    Reviewed-on: https://code.wireshark.org/review/9914
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  018e93a   Another unnecessary include of io.h.
    adds  35a1383   Major Re-factoring of the dissector and some new features.


Summary of changes:
 epan/dissectors/packet-cip.c   |   26 +-
 epan/dissectors/packet-mbtcp.c | 1453 +++++++++++++++++++++-------------------
 epan/dissectors/packet-mbtcp.h |   30 +-
 3 files changed, 789 insertions(+), 720 deletions(-)