Wireshark-commits: [Wireshark-commits] master-2.0 08a07fd: Fix AddressSanitizer (./configure --enab
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Nov 2015 12:29:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08a07fd3b0f05522d631a6b36de208b0e89cacdf
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

08a07fd by Dhiru Kholia (kholia@xxxxxx):

    Fix AddressSanitizer (./configure --enable-asan) builds
    
    "./configure --enable-asan" currently fails to detect installed libraries
    because aclocal-fallback/* built programs have memory leaks in them.
    
    configure:34516: checking for GTK+ - version >= 3.0.0
    configure:34626: gcc -o conftest ...
    ...
    configure:34626: $? = 0
    configure:34626: ./conftest
    
    =================================================================
    ==29007==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 6 byte(s) in 1 object(s) allocated from:
        #0 0x7fa5c95dd9aa in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x989aa)
        #1 0x7fa5c8995578 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f578)
    
    SUMMARY: AddressSanitizer: 6 byte(s) leaked in 1 allocation(s).
    configure:34626: $? = 23
    configure: program exited with status 23
    ...
    configure:34649: result: no
    configure:34699: error: GTK+ 3 is not available
    
    ...
    
    This system is running 64-bit Ubuntu Linux 15.10 with GCC 5.2.1
    compiler.
    
    The glib-2-0.m4 leak, and the gtk-3.0.m4 leak are fixed by updating
    "glib-2.0.m4" to the latest upstream version.
    
    Whitespace errors are fixed locally to keep the BuildBot happy.
    
    Change-Id: I01a5f4c494a59ae6d0ee19cd2611fab163ebf9b4
    Reviewed-on: https://code.wireshark.org/review/11283
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 58528f6d911c7dfec3c8c550abc5d717861c60ee)
    Reviewed-on: https://code.wireshark.org/review/11552
    

Actions performed:

    from  26be84f   [OpenFlow] Use correct name for flag OFPMPF_REPLY_MORE in v5 dissector
    adds  08a07fd   Fix AddressSanitizer (./configure --enable-asan) builds


Summary of changes:
 aclocal-fallback/glib-2.0.m4 |   56 ++++++++++++++++++------------------
 aclocal-fallback/gtk-2.0.m4  |    5 +---
 aclocal-fallback/gtk-3.0.m4  |   64 +++++++++++++++++++++++++++++-------------
 3 files changed, 73 insertions(+), 52 deletions(-)