Wireshark-commits: [Wireshark-commits] master-2.0 acbb4ac: ISIS Hello: Restore correct dissection o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 Nov 2015 20:21:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acbb4ac298d61d5be518dee7f472e096b5d65972
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

acbb4ac by Jim Young (jyoung@xxxxxxx):

    ISIS Hello: Restore correct dissection of SPB BVID
    
    Commit 301a5b7ceac60d0569ce1717e839241d1072400 introduced a small
    regression with the dissection of the BVID.  BVID should be extracted
    from the 12 most significant bits not the 12 least significant bits.
    Make it so.
    
    Change-Id: Idcf0492eea1f6cb7282641ae243aa7092e5a1418
    Reviewed-on: https://code.wireshark.org/review/11472
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 56d01272474f9022a0ace0011f649dd59f573813)
    Reviewed-on: https://code.wireshark.org/review/11503
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d64a210   BER: Removed erroneous callback from dissect_ber_external_U
    adds  acbb4ac   ISIS Hello: Restore correct dissection of SPB BVID


Summary of changes:
 epan/dissectors/packet-isis-hello.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)