Wireshark-commits: [Wireshark-commits] master db760bf: Qt: Allow Expert Information retapping.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Oct 2015 20:11:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db760bf52eafe728ab9be0e40760cda5e536572b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

db760bf by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Allow Expert Information retapping.
    
    The Expert Information dialog is open-ended. It adds a tap listener but
    doesn't remove it, which is useful during live captures. Make sure we
    add our second-level tree items each time taps are drawn and when
    tapping is finished.
    
    Change-Id: Ie06d60512644e540172f1b330b631db4e4e86897
    Bug: 11644
    Reviewed-on: https://code.wireshark.org/review/11407
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f449dcd   Qt: Add the ability to add filter expressions.
    adds  db760bf   Qt: Allow Expert Information retapping.


Summary of changes:
 ui/qt/expert_info_dialog.cpp |   57 ++++++++++++++++++++++++++----------------
 ui/qt/expert_info_dialog.h   |    3 +++
 2 files changed, 39 insertions(+), 21 deletions(-)