Wireshark-commits: [Wireshark-commits] master 4c69f10: Qt: initialize all UAT fields when creating
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Oct 2015 13:58:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c69f10aa42070616b92886f104f5a16eb88f00c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4c69f10 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: initialize all UAT fields when creating a new line
    
    Otherwise it can trigger a crash when calling the callback while some fields have a NULL pointer (SSL post_update_cb for example)
    
    Change-Id: I25ac97d8e0bbf47e737f74029715358cb29cfb3d
    Reviewed-on: https://code.wireshark.org/review/11334
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d1f0e72   frame_data: Reset subnum if visited is resetted
    adds  4c69f10   Qt: initialize all UAT fields when creating a new line


Summary of changes:
 ui/qt/uat_dialog.cpp |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)