Wireshark-commits: [Wireshark-commits] master 7a9237f: [ssl] dissect handshake messages even if we
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 21:48:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a9237fb21ac2c771a741f1baaab762354e23c24
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7a9237f by Martin Kaiser (wireshark@xxxxxxxxx):

    [ssl] dissect handshake messages even if we have no tree
    
    this is to make sure that all expert info we see in the
    main window will also appear in the expert info window
    
    the sample capture from bug 11561 shows this problem:
    without this patch, the expert info with severity 'error'
    don't show up in the expert info window
    
    Change-Id: Ia71ae7e248f57bf1344cf722ac57e74c517828d5
    Reviewed-on: https://code.wireshark.org/review/11246
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8869d57   RADIUS: Use directly tvb_ip*_to_str
    adds  7a9237f   [ssl] dissect handshake messages even if we have no tree


Summary of changes:
 epan/dissectors/packet-dtls.c      |   39 +++++++--------
 epan/dissectors/packet-ssl-utils.c |   92 ++++++++++++++++++------------------
 epan/dissectors/packet-ssl.c       |   43 +++++++----------
 3 files changed, 80 insertions(+), 94 deletions(-)