Wireshark-commits: [Wireshark-commits] master e2203f5: Qt: fix memory leaks in VoIP calls window
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Oct 2015 11:07:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2203f5aed1eef900c7568b6d14f3e303e271b7c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e2203f5 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix memory leaks in VoIP calls window
    
    - Add free of h245_labels to voip_calls_remove_all_tap_listeners() so that memory is not leaked with Qt GUI
    - Call voip_calls_reset_all_taps() from VoipCallsDialog destructor so as to free allocated memory
    
    Change-Id: I46945b5d475d8c1267819021a4ed2782c531a0c6
    Reviewed-on: https://code.wireshark.org/review/11268
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  5dffa81   EPL: add explicit casts to please OSX 10.5 x86 buildbot
    adds  e2203f5   Qt: fix memory leaks in VoIP calls window


Summary of changes:
 ui/qt/voip_calls_dialog.cpp |    2 ++
 ui/voip_calls.c             |   16 ++++++++--------
 2 files changed, 10 insertions(+), 8 deletions(-)