Wireshark-commits: [Wireshark-commits] master-2.0 b315d45: Allocate h245_labels when we initialize
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Oct 2015 09:44:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b315d459c568504adb1490f1ed144b2bd3fea640
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b315d45 by Guy Harris (guy@xxxxxxxxxxxx):

    Allocate h245_labels when we initialize the h245dg tap.
    
    Otherwise, it might not exist at the time we try to use it.  (Yes,
    reproducible if you download
    
    	https://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=h223-over-rtp.pcap.gz
    
    load it into Wireshark and, at least in the Qt UI, select Telephony ->
    VoIP Calls - crashes every time on my Mac running Yosemite.)
    
    Change-Id: Iacf5b8ef7fb5749dabeb5fc33d3494b5fc073c03
    Reviewed-on: https://code.wireshark.org/review/11277
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit fb72cad4e87e1ed37c6e0624a5c7c75bba6ee394)
    Reviewed-on: https://code.wireshark.org/review/11278
    

Actions performed:

    from  258a41e   There's no need for all these variables to be volatile.
    adds  b315d45   Allocate h245_labels when we initialize the h245dg tap.


Summary of changes:
 ui/voip_calls.c |    6 ++++++
 1 file changed, 6 insertions(+)