Wireshark-commits: [Wireshark-commits] lts-1.8.2 e0c9f25: WaveAgent - Use tvb_get_guint8 instead of
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Oct 2015 09:16:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0c9f257b6ebe44a14b74af4016dd8595ec39ed9
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

e0c9f25 by Michael Mann (mmann78@xxxxxxxxxxxx):

    WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value
    
    Conflicts:
    	epan/dissectors/packet-waveagent.c
    
    Ping-Bug: 11358
    Change-Id: I9ecb5fe6bcd7f25c763d968bf56fb2d9bce2180c
    Reviewed-on: https://code.wireshark.org/review/9639
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 5523726e6960fe9d7e301376fd7a94599f65fd42)
    Reviewed-on: https://code.wireshark.org/review/9653
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1c1733e4be25c1e125e02f9eae2c7dc2e0206bf4)
    Reviewed-on: https://code.wireshark.org/review/10586
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/11259
    

Actions performed:

    from  4be8823   Protect dissector_get_(default_)string_handle() against NULL input string
    adds  e0c9f25   WaveAgent - Use tvb_get_guint8 instead of tvb_get_ptr to walk a packet and protect against a really big tag value


Summary of changes:
 epan/dissectors/packet-waveagent.c |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)