Wireshark · Wireshark-commits: [Wireshark-commits] master 08a2070: Do -fPIC only if it's necessary.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=08a20705b4d03cb4460e13d3c270077930a75310
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

08a2070 by Guy Harris (guy@xxxxxxxxxxxx):

    Do -fPIC only if it's necessary.
    
    Or, at least, undo the unconditional addition of -fPIC to
    Qt5Widgets_EXECUTABLE_COMPILE_FLAGS, and add it back only if we need it
    to compile a small test program that includes <QtCore>.
    
    -fPIC still shows up for other reasons; perhaps we need to undo other
    unconditional operations "helpfully" done by Qt5CoreConfigExtras.cmake.
    
    Change-Id: I76c1b01b3dce7398e4115552bc4ff87bc775e027
    Reviewed-on: https://code.wireshark.org/review/11079
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b0b53fa   On UN*X, use XDG_CONFIG_HOME/wireshark for configuration files.
    adds  08a2070   Do -fPIC only if it's necessary.


Summary of changes:
 CMakeLists.txt |   48 ++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)