Wireshark-commits: [Wireshark-commits] master 4ff0290: x11 generator: Don't crash when a switch is
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Oct 2015 14:52:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ff02903a65dc9dcc8bd97613e46a6736cda46a1
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4ff0290 by Peter Harris (pharris@xxxxxxxxxxxx):

    x11 generator: Don't crash when a switch is in a struct
    
    The size calculation for the struct will be wrong (too small) which looks
    strange in the GUI when the children elements extend past the region
    marked by their parent. But it doesn't seem to cause any actual problems,
    there is only one request affected by this, and correct size calculation
    (by recursing the switch) would take a fair amount of work.
    
    Change-Id: I1847f736153daf59b8dbf3299005a772ffe9673a
    Reviewed-on: https://code.wireshark.org/review/11107
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  0f2eb38   x11 generator: Fix struct size with array
    adds  4ff0290   x11 generator: Don't crash when a switch is in a struct


Summary of changes:
 tools/process-x11-xcb.pl |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)