Wireshark-commits: [Wireshark-commits] master-2.0 5587f3b: nstime: fix -Wshift-negative-value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Oct 2015 11:41:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5587f3be6726554071348ec00eb9489d9008aaff
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5587f3b by Peter Wu (peter@xxxxxxxxxxxxx):

    nstime: fix -Wshift-negative-value
    
    Even if the result of the negative shift (in TIME_T_MIN) is not used
    because the signedness check happens before, it still causes a
    compile-time warning. Fix this by shifting on an unsigned value, then
    truncate by casting it.
    
    While at it, remove a "fix for broken SCO compiler", it might not apply
    to us (fingers crossed).
    
    Change-Id: Id9603149d8063e9eaaa65cf028323f10e60a6c42
    Reviewed-on: https://code.wireshark.org/review/10862
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit b07226775e920b6e2fc39e98d9f92faa5f35b017)
    Reviewed-on: https://code.wireshark.org/review/11058
    

Actions performed:

    from  aa4e616   Remove unused offset variables.
    adds  5587f3b   nstime: fix -Wshift-negative-value


Summary of changes:
 wsutil/nstime.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)