Wireshark-commits: [Wireshark-commits] master-2.0 c3f57b2: Change proto_tree_add_ipv6() to take a s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Oct 2015 12:18:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3f57b2258cd39ceb57a13e1fbf6a2f77e1c4249
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

c3f57b2 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Change proto_tree_add_ipv6() to take a struct e_in6_addr pointer
    
    tvb_get_ipv6() takes a struct e_in6_addr *, use that here too.
    
    Change-Id: Id8b368daa05c151a61d4bc01dc88c00da13e9c88
    Reviewed-on: https://code.wireshark.org/review/10953
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit a643d14187c5a201d21bdb0786acc5e27b73a3a1)
    Reviewed-on: https://code.wireshark.org/review/11008
    

Actions performed:

    from  508c182   gtk: add asserts.
    adds  c3f57b2   Change proto_tree_add_ipv6() to take a struct e_in6_addr pointer


Summary of changes:
 epan/dissectors/packet-6lowpan.c       |   12 ++++++------
 epan/dissectors/packet-bgp.c           |    8 +++-----
 epan/dissectors/packet-dcerpc.c        |    2 +-
 epan/dissectors/packet-diameter.c      |    2 +-
 epan/dissectors/packet-dns.c           |    6 +++---
 epan/dissectors/packet-eigrp.c         |    2 +-
 epan/dissectors/packet-ftp.c           |    4 ++--
 epan/dissectors/packet-icmpv6.c        |   10 +++++-----
 epan/dissectors/packet-ipv6.c          |    8 ++++----
 epan/dissectors/packet-isis-clv.c      |    6 +++---
 epan/dissectors/packet-isis-lsp.c      |    2 +-
 epan/dissectors/packet-nfs.c           |    2 +-
 epan/dissectors/packet-nsip.c          |    2 +-
 epan/dissectors/packet-ospf.c          |    2 +-
 epan/dissectors/packet-packetbb.c      |    2 +-
 epan/dissectors/packet-pim.c           |   12 ++++++------
 epan/dissectors/packet-ppcap.c         |    4 ++--
 epan/dissectors/packet-ppp.c           |    4 ++--
 epan/dissectors/packet-rtpproxy.c      |    8 ++++----
 epan/dissectors/packet-sasp.c          |    2 +-
 epan/dissectors/packet-socks.c         |    2 +-
 epan/dissectors/packet-stun.c          |    2 +-
 epan/dissectors/packet-wccp.c          |    4 ++--
 epan/dissectors/packet-wsp.c           |    2 +-
 epan/dissectors/packet-zebra.c         |    2 +-
 epan/proto.c                           |    9 +++++----
 epan/proto.h                           |    6 +++---
 plugins/wimaxasncp/packet-wimaxasncp.c |    2 +-
 28 files changed, 64 insertions(+), 65 deletions(-)