Wireshark-commits: [Wireshark-commits] master 2f454a3: ssl-utils: fix anchoring matches in keylog f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Oct 2015 07:35:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f454a3f8c5c8d87b346c5b52ce5846625b7053c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2f454a3 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: fix anchoring matches in keylog file
    
    Somehow "# CLIENT_RANDOM" would also be matched by the regex. It turns
    out that glib requires two flags to enable anchoring.
    
    This issue also causes silent truncation of keylog lines rather than
    reporting no match.
    
    Change-Id: Ib51265b6ec428988c222b4f3bc3cbc99ef0d72bf
    Reviewed-on: https://code.wireshark.org/review/10933
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a386fc9   ssl-utils: Fix parsing pre-master-secrets in keylog-file
    adds  2f454a3   ssl-utils: fix anchoring matches in keylog file


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)