Wireshark-commits: [Wireshark-commits] master-2.0 55fa261: NTP: fix dissection of SHA1 based messag
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Oct 2015 05:49:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55fa261bca42234616a6bb365fb7e02606a45820
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

55fa261 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NTP: fix dissection of SHA1 based message authentication code
    
    The maximum MAC length is 160 bits, not 128. MAX_MAC_LEN can be safely
    increased as an extension should be > 4 bytes.
    
    Bug: 11580
    Change-Id: I0ea5a1f85d644e57315f033f09241d7a79dd3a45
    Reviewed-on: https://code.wireshark.org/review/10934
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 52e5ada040e2697e3f3e6a43bb847481a7884609)
    Reviewed-on: https://code.wireshark.org/review/10948
    

Actions performed:

    from  48f1b75   Handle installing Qt 4.x.
    adds  55fa261   NTP: fix dissection of SHA1 based message authentication code


Summary of changes:
 epan/dissectors/packet-ntp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)