Wireshark-commits: [Wireshark-commits] master a7ab4af: airpdcap: add free_key_string function, fix
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Oct 2015 14:35:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7ab4af2ab4db5d5fdd5d489bf6b4171a8b1b8d9
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a7ab4af by Peter Wu (peter@xxxxxxxxxxxxx):

    airpdcap: add free_key_string function, fix memleaks
    
    Do not leak the key and SSID. Note that there are still some leaks in
    the GTK UI related to get_wireshark_keys(), but I did not track them
    down.
    
    Caught by LeakSanitizer.
    
    Change-Id: I639166e6ea457605d6ae0ebd58e56d7594a7b7db
    Reviewed-on: https://code.wireshark.org/review/10860
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  3dd7e69   WSP: Fix add_addresses()
    adds  a7ab4af   airpdcap: add free_key_string function, fix memleaks


Summary of changes:
 debian/libwireshark0.symbols       |    1 +
 epan/crypt/airpdcap.c              |   10 ++++++++++
 epan/crypt/airpdcap_user.h         |   11 ++++++++++-
 epan/dissectors/packet-ieee80211.c |   10 ++++++----
 ui/gtk/airpcap_gui_utils.c         |    6 +-----
 5 files changed, 28 insertions(+), 10 deletions(-)