Wireshark-commits: [Wireshark-commits] master c4f00a8: AMQP: Fix usage of p_(add|get)_proto_data.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Oct 2015 12:08:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4f00a825d318777b7e29168996988eb2e495b13
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c4f00a8 by Petr Gotthard (petr.gotthard@xxxxxxxxxxxxx):

    AMQP: Fix usage of p_(add|get)_proto_data.
    
    The p_(add|get)_proto_data() functions are used to store data related
    to an AMQP frame. The stored information gets overwritten if there are
    multiple small AMQP frames in one TCP/IP packet.
    
    As suggested by Pascal and https://code.wireshark.org/review/#/c/10579/,
    we should use tvb_raw_offset as key for p_(add|get)_proto_data().
    
    Change-Id: I860df8af51a6fbbef495985747313ae96402cc5c
    Reviewed-on: https://code.wireshark.org/review/10836
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  8695303   IPv6: add changes forgotten in gbedda9b
    adds  c4f00a8   AMQP: Fix usage of p_(add|get)_proto_data.


Summary of changes:
 epan/dissectors/packet-amqp.c |   67 ++++++++++++++++++-----------------------
 1 file changed, 29 insertions(+), 38 deletions(-)