Wireshark-commits: [Wireshark-commits] master 89b227f: qt: fix crash when dragging RTP player out o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Oct 2015 18:44:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=89b227f44edf224e9f4478947319f7fffe74fcf3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

89b227f by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: fix crash when dragging RTP player out of view
    
    Fix invalid memory access when dragging the RTP player out of view when
    a stream is selected. lowerBound() returns QMap.end() when no item is
    found, use that instead.
    
    Found using ASAN.
    
    Change-Id: I5444a047bc242dfe481bd0581c5217030fca28f1
    Reviewed-on: https://code.wireshark.org/review/10778
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  076d07d   [isns]: use proto_tree_add_bitmask() for the iscsi node type
    adds  89b227f   qt: fix crash when dragging RTP player out of view


Summary of changes:
 ui/qt/rtp_audio_stream.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)