Wireshark-commits: [Wireshark-commits] master 71ec57a: bacapp: fix -Wshift-negative-value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Oct 2015 13:43:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71ec57ab8bde0c414a03969cb00a1412179f7e37
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

71ec57a by Peter Wu (peter@xxxxxxxxxxxxx):

    bacapp: fix -Wshift-negative-value
    
    Shifting a negative signed value is undefined. Found by Clang.
    
    Change-Id: If58d7b82899859892d8c58d627e98a8a902dd7fd
    Reviewed-on: https://code.wireshark.org/review/10780
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5c17f1f   Add preference to dissect DHCPv6 option 18 as a CableLab option.
    adds  71ec57a   bacapp: fix -Wshift-negative-value


Summary of changes:
 epan/dissectors/packet-bacapp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)