Wireshark-commits: [Wireshark-commits] lts-1.12.1 d38776a: Don't try to decrypt the payload if it w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2015 20:39:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d38776a99cff2c596e2a8c902bcd33bd3d32a372
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

d38776a by Guy Harris (guy@xxxxxxxxxxxx):

    Don't try to decrypt the payload if it was cut short by the snapshot length.
    
    It's not clear that the decryption code can handle an incomplete
    payload.  If it can, please fix this (bear in mind that you won't have
    all the MIC, and may not have *any* of the MIC, so...).
    
    Bug: 11389
    Change-Id: If97fee05c03d59580d790cb79da6455b615596c1
    Reviewed-on: https://code.wireshark.org/review/9957
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 39e61530847678939a4d248e3d01e4b366cb7539)
    Reviewed-on: https://code.wireshark.org/review/10617
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  1f21835   Use the reported length where appropriate.
    adds  d38776a   Don't try to decrypt the payload if it was cut short by the snapshot length.


Summary of changes:
 epan/dissectors/packet-zbee-security.c |   46 ++++++++++++++++++++++----------
 1 file changed, 32 insertions(+), 14 deletions(-)