Wireshark-commits: [Wireshark-commits] master 4680c8b: Revert "Report an error if we fail to open t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Sep 2015 14:58:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4680c8b42904d7fdda9ba1175e3e808953912bad
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4680c8b by Peter Wu (peter@xxxxxxxxxxxxx):

    Revert "Report an error if we fail to open the keylog file."
    
    This reverts commit d1fcb7dd3482decd70bc3da6fbdef81800f0320f.
    
    Warning the user multiple times about an invalid ssl.keylog_file every
    time a SSL stream is encountered is an annoyance (in tshark), but
    crashing in GTK+/Qt during live captures is even worse.
    
    Disable the warning for now. Maybe detect it once at startup? That would
    not cover removed files though.
    
    Bug: 11488
    Change-Id: I56b2eba1df0cff2309584a745b55ada238999fc4
    Reviewed-on: https://code.wireshark.org/review/9687
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  5e635ad   ssl: determine DTLS by positively checking for UDP
    adds  4680c8b   Revert "Report an error if we fail to open the keylog file."


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)