Wireshark-commits: [Wireshark-commits] master e2735ec: Remove proto_tree_add_text API.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Sep 2015 14:11:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2735ecfdd7a96ce909cf5e2be27da1d49d7b321
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e2735ec by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove proto_tree_add_text API.
    
    Its time has finally come.
    
    Technically I just renamed it to proto_tree_add_text_internal and removed the WS_DLL_PUBLIC (so it shouldn't link outside of epan).  It's still (legitimately) used by expert.c otherwise I would have made it static within proto.c (and the rename wouldn't have been necessary).
    
    Change-Id: I9bdf888d5e92bc7b70a3f5461b9297a66d994b80
    Reviewed-on: https://code.wireshark.org/review/10594
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3b09a9e   nfs: Register CB program statically and not whilst parsing it
    adds  e2735ec   Remove proto_tree_add_text API.


Summary of changes:
 debian/libwireshark0.symbols   |    1 -
 docbook/release-notes.asciidoc |    1 +
 epan/expert.c                  |    4 +--
 epan/expert.h                  |   10 +++----
 epan/proto.c                   |   16 +++++-----
 epan/proto.h                   |   16 ++++------
 tools/checkAPIs.pl             |   64 ----------------------------------------
 7 files changed, 21 insertions(+), 91 deletions(-)