Wireshark-commits: [Wireshark-commits] master 69d2d58: pkcs1: remove unused RSAPrivateKey definitio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Sep 2015 04:00:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=69d2d585aa5a96e6ab5b1ead049a7ee79f50060e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

69d2d58 by Peter Wu (peter@xxxxxxxxxxxxx):

    pkcs1: remove unused RSAPrivateKey definition
    
    RSA private keys are typically not found in network captures, so let's
    just remove it. This removal avoids overloading the pkcs1.modulus
    field with the same meaning from two different contexts (RSAPrivateKey
    and RSAPublicKey).
    
    Change-Id: I65239718e6fc801fc53fa46c467dc86620aa3b29
    Reviewed-on: https://code.wireshark.org/review/10546
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7e17b58   When we're updating the progress bar, ask that it be updated (redrawn) too.
    adds  69d2d58   pkcs1: remove unused RSAPrivateKey definition


Summary of changes:
 asn1/pkcs1/PKIXAlgs-2009.asn   |   14 --------
 asn1/pkcs1/pkcs1.cnf           |    1 -
 epan/dissectors/packet-pkcs1.c |   69 ----------------------------------------
 epan/dissectors/packet-pkcs1.h |    1 -
 4 files changed, 85 deletions(-)