Wireshark-commits: [Wireshark-commits] master 6646b00: ncp2222 - Convert process_bitfield -> proto_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Sep 2015 18:24:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6646b00b5f7606a179614f7d5ba6d7f62cea0b64
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6646b00 by Michael Mann (mmann78@xxxxxxxxxxxx):

    ncp2222 - Convert process_bitfield -> proto_tree_add_bitmask and other cleanup.
    
    The dissector is doing a lot of unnecessary "manual" operations.  Start the process of simplifying that to encourage use of general APIs and put control of the "field name" in the hands of the hf_ entry it belongs with.
    
    Change-Id: I5b048c04858ac4a846a276ba12d61c665deb66f8
    Reviewed-on: https://code.wireshark.org/review/10547
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a4c2a29   [iax2] don't THROW() an exception from a dissector
    adds  6646b00   ncp2222 - Convert process_bitfield -> proto_tree_add_bitmask and other cleanup.


Summary of changes:
 epan/dissectors/packet-ncp2222.inc | 1402 ++++++++++--------------------------
 tools/ncp2222.py                   |  131 +++-
 2 files changed, 499 insertions(+), 1034 deletions(-)