Wireshark-commits: [Wireshark-commits] master 1345722: dtls: remove unneeded private key file looku
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Sep 2015 10:10:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=134572289efaf48dcb5aae96fae4e223c798044a
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1345722 by Peter Wu (peter@xxxxxxxxxxxxx):

    dtls: remove unneeded private key file lookup
    
    The comment was valid, the private key is already looked during the
    ClientHello message (using ssl_find_private_key) and since the key is
    only used during the key exchange, it is not needed to look it up that
    early.
    
    Verified with the test suite (DTLS Decryption).
    
    Change-Id: Ia084a40d98cd74c77e9f1659ac57eeb8d44e59b6
    Reviewed-on: https://code.wireshark.org/review/10529
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a0cfeab   SSL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  1345722   dtls: remove unneeded private key file lookup


Summary of changes:
 epan/dissectors/packet-dtls.c |   37 -------------------------------------
 1 file changed, 37 deletions(-)