Wireshark-commits: [Wireshark-commits] master cf49f71: dissector-skinny: Update skinny dissector to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Sep 2015 19:24:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf49f71c59b4b418ae04e4b70cac63f7f0b902ed
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cf49f71 by Diederik de Groot (ddegroot@xxxxxxxx):

    dissector-skinny: Update skinny dissector to fix ServerRes Message
    
    ServerRes message does not follow other message when it comes to
    provinding the list of ip-addresses. The type of ip-address (IPv4
    or IPv6 does not depend on the protocol version but the length of
    the message.
    
    Fix: ipv4 address displayed as ip-address
    
    Change-Id: Ie16f81c9482b30a80da37b9327b09e933d7808f8
    Reviewed-on: https://code.wireshark.org/review/10513
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f2c5dee   Qt: refresh column content after editing it
    adds  cf49f71   dissector-skinny: Update skinny dissector to fix ServerRes Message


Summary of changes:
 epan/dissectors/packet-skinny.c     |   39 ++++++++++++++++++++++++++---------
 tools/SkinnyProtocolOptimized.xml   |   19 ++++++++++++-----
 tools/parse_xml2skinny_dissector.py |   13 ++++++++++++
 3 files changed, 56 insertions(+), 15 deletions(-)