Wireshark-commits: [Wireshark-commits] master 648cf99: Make other_decode_bitfield_value private to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Sep 2015 00:15:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=648cf995b108ae2cb6df83e1144b32f34ffb8028
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

648cf99 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make other_decode_bitfield_value private to proto.c.
    
    This is further encouragement to not try to manually create a bitstring while formatting a field.
    
    Change-Id: I4efbeb39a210cf1fd26203cd8560859276b333b0
    Reviewed-on: https://code.wireshark.org/review/10494
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e4c0e51   IPv4: Add missing space to format string
    adds  648cf99   Make other_decode_bitfield_value private to proto.c.


Summary of changes:
 asn1/camel/packet-camel-template.c |   11 ++---------
 debian/libwireshark0.symbols       |    1 -
 epan/dissectors/packet-ansi_a.c    |   11 +----------
 epan/dissectors/packet-camel.c     |   21 +++++++--------------
 epan/proto.c                       |   35 +++++++++++++++++++++++++++++++++++
 epan/to_str.c                      |   35 -----------------------------------
 epan/to_str.h                      |    3 ---
 7 files changed, 45 insertions(+), 72 deletions(-)