Wireshark-commits: [Wireshark-commits] master 80322d8: dfilter: Add membership operator
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Sep 2015 06:31:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80322d88da92969c170c915e93a33a96e12497a7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

80322d8 by Jeffrey Smith (whydoubt@xxxxxxxxx):

    dfilter: Add membership operator
    
    Added a new relational test: 'x in {a b c}'.  The only LHS entity
    supported at this time is a field.  The generated DFVM operations are
    equivalent to an OR'ed series of =='s, but with the redundant existence
    tests removed.
    
    Change-Id: Iddc89b81cf7ad6319aef1a2a94f93314cb721a8a
    Reviewed-on: https://code.wireshark.org/review/10246
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  86d8b8d   usb: fix 'index' var name
    adds  80322d8   dfilter: Add membership operator


Summary of changes:
 dfilters                                        |    2 +-
 doc/README.display_filter                       |    1 +
 doc/wireshark-filter.pod                        |   12 ++++
 doc/wireshark.pod.template                      |    2 +-
 docbook/wsug_src/WSUG_chapter_work.asciidoc     |   13 ++++
 epan/CMakeLists.txt                             |    1 +
 epan/dfilter/Makefile.common                    |    2 +
 epan/dfilter/gencode.c                          |   79 +++++++++++++++++++++++
 epan/dfilter/grammar.lemon                      |   24 +++++++
 epan/dfilter/scanner.l                          |    6 ++
 epan/dfilter/semcheck.c                         |   60 ++++++++++++++++-
 epan/dfilter/{sttype-pointer.c => sttype-set.c} |   48 +++++++++-----
 epan/dfilter/{gencode.h => sttype-set.h}        |   16 +++--
 epan/dfilter/sttype-test.c                      |    1 +
 epan/dfilter/sttype-test.h                      |    3 +-
 epan/dfilter/syntax-tree.c                      |    1 +
 epan/dfilter/syntax-tree.h                      |    2 +
 17 files changed, 245 insertions(+), 28 deletions(-)
 copy epan/dfilter/{sttype-pointer.c => sttype-set.c} (65%)
 copy epan/dfilter/{gencode.h => sttype-set.h} (82%)