Wireshark-commits: [Wireshark-commits] master a2fec21: Check if -fPIC is needed for Qt5 code to com
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 10 Sep 2015 13:00:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2fec2188654bd80ae8567862c546c33bf5eb698
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a2fec21 by Jeffrey Smith (whydoubt@xxxxxxxxx):

    Check if -fPIC is needed for Qt5 code to compile
    
    On many systems, Qt5 requires that code compiled against it must compile
    with -fPIC.  The preferred place to determine whether this is necessary
    is at configure time.  This change adds the auto-tool code to make that
    happen and removes the hack put in place as an interim solution.
    
    Bug: 11230
    Change-Id: I6e583c67bb67d168a30c0af05a8cd0a070522ba0
    Reviewed-on: https://code.wireshark.org/review/10281
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  5eee0b9   Don't use any -fsanitize options unless we're using ASAN.
    adds  a2fec21   Check if -fPIC is needed for Qt5 code to compile


Summary of changes:
 acinclude.m4      |   30 ++++++++++++++++++++++++++++++
 ui/qt/Makefile.am |    2 +-
 2 files changed, 31 insertions(+), 1 deletion(-)