Wireshark-commits: [Wireshark-commits] master 0e9389b: Display filter edit updates.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Sep 2015 01:43:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e9389bb47e54ff0f4bbc288cb1adfde4a9ed045 Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 0e9389b by Gerald Combs (gerald@xxxxxxxxxxxxx): Display filter edit updates. Have the bookmark button operate on saved display filters, similar to the "Filter:" button in the GTK+ UI. Expose the saved display filter list via a popup menu. Update the display filter icons. Make the "Apply" button wider. Remove the old icon assets. Add a StockIconToolButton class along with note explaining why it's necessary. Rename the "Filter Bookmarks" preference to "Filter Shortcuts". Suggestion for a better name are welcome. Change-Id: I0082d3f01b017253fa75e51cbff9beb17c41a209 Reviewed-on: https://code.wireshark.org/review/10390 Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx> Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Actions performed: from 4f5937a Qt: Fixed a QString memory leak adds 0e9389b Display filter edit updates. Summary of changes: Makefile.am | 1 - image/dfilter_apply_disabled.png | Bin 181 -> 0 bytes image/dfilter_apply_hover.png | Bin 182 -> 0 bytes image/dfilter_apply_normal.png | Bin 182 -> 0 bytes image/dfilter_apply_pressed.png | Bin 182 -> 0 bytes image/dfilter_bookmark_disabled.png | Bin 420 -> 0 bytes image/dfilter_bookmark_hover.png | Bin 384 -> 0 bytes image/dfilter_bookmark_normal.png | Bin 384 -> 0 bytes image/dfilter_bookmark_pressed.png | Bin 384 -> 0 bytes image/dfilter_dropdown.png | Bin 123 -> 0 bytes image/dfilter_erase_active.png | Bin 174 -> 0 bytes image/dfilter_erase_normal.png | Bin 184 -> 0 bytes image/dfilter_erase_selected.png | Bin 174 -> 0 bytes image/dfilter_refresh_active.png | Bin 267 -> 0 bytes image/dfilter_refresh_normal.png | Bin 262 -> 0 bytes image/display_filter.qrc | 18 - image/toolbar.qrc | 26 + image/toolbar/14x14/x-filter-bookmark.active.png | Bin 0 -> 254 bytes image/toolbar/14x14/x-filter-bookmark.active.svg | 109 +++ .../toolbar/14x14/x-filter-bookmark.active@xxxxxx | Bin 0 -> 403 bytes image/toolbar/14x14/x-filter-bookmark.png | Bin 0 -> 238 bytes image/toolbar/14x14/x-filter-bookmark.selected.png | Bin 0 -> 258 bytes image/toolbar/14x14/x-filter-bookmark.selected.svg | 109 +++ .../14x14/x-filter-bookmark.selected@xxxxxx | Bin 0 -> 400 bytes image/toolbar/14x14/x-filter-bookmark.svg | 109 +++ image/toolbar/14x14/x-filter-bookmark@xxxxxx | Bin 0 -> 392 bytes image/toolbar/14x14/x-filter-clear.active.png | Bin 0 -> 285 bytes image/toolbar/14x14/x-filter-clear.active.svg | 126 +++ image/toolbar/14x14/x-filter-clear.active@xxxxxx | Bin 0 -> 504 bytes image/toolbar/14x14/x-filter-clear.png | Bin 0 -> 277 bytes image/toolbar/14x14/x-filter-clear.selected.png | Bin 0 -> 287 bytes image/toolbar/14x14/x-filter-clear.selected.svg | 126 +++ image/toolbar/14x14/x-filter-clear.selected@xxxxxx | Bin 0 -> 508 bytes image/toolbar/14x14/x-filter-clear.svg | 125 +++ image/toolbar/14x14/x-filter-clear@xxxxxx | Bin 0 -> 480 bytes image/toolbar/14x14/x-filter-dropdown.png | Bin 0 -> 120 bytes image/toolbar/14x14/x-filter-dropdown.svg | 107 +++ image/toolbar/14x14/x-filter-dropdown@xxxxxx | Bin 0 -> 146 bytes .../14x14/x-filter-matching-bookmark.active.png | Bin 0 -> 241 bytes .../14x14/x-filter-matching-bookmark.active.svg | 109 +++ .../14x14/x-filter-matching-bookmark.active@xxxxxx | Bin 0 -> 406 bytes image/toolbar/14x14/x-filter-matching-bookmark.png | Bin 0 -> 237 bytes .../14x14/x-filter-matching-bookmark.selected.png | Bin 0 -> 236 bytes .../14x14/x-filter-matching-bookmark.selected.svg | 109 +++ .../x-filter-matching-bookmark.selected@xxxxxx | Bin 0 -> 417 bytes image/toolbar/14x14/x-filter-matching-bookmark.svg | 109 +++ .../14x14/x-filter-matching-bookmark@xxxxxx | Bin 0 -> 385 bytes image/toolbar/24x14/x-filter-apply.active.png | Bin 0 -> 388 bytes image/toolbar/24x14/x-filter-apply.active.svg | 128 +++ image/toolbar/24x14/x-filter-apply.active@xxxxxx | Bin 0 -> 632 bytes image/toolbar/24x14/x-filter-apply.png | Bin 0 -> 365 bytes image/toolbar/24x14/x-filter-apply.selected.png | Bin 0 -> 395 bytes image/toolbar/24x14/x-filter-apply.selected.svg | 128 +++ image/toolbar/24x14/x-filter-apply.selected@xxxxxx | Bin 0 -> 647 bytes image/toolbar/24x14/x-filter-apply.svg | 128 +++ image/toolbar/24x14/x-filter-apply@xxxxxx | Bin 0 -> 583 bytes image/toolbar/svg-to-png.sh | 34 +- image/toolbar/svg/x-filter-apply.svg | 133 +++ image/toolbar/svg/x-filter-bookmark.svg | 77 ++ image/toolbar/svg/x-filter-clear.svg | 77 ++ ui/qt/CMakeLists.txt | 1 - ui/qt/Makefile.common | 1 - ui/qt/Wireshark.pro | 1 - ui/qt/capture_filter_combo.cpp | 2 +- ui/qt/display_filter_16.svg | 901 -------------------- ui/qt/display_filter_combo.cpp | 2 +- ui/qt/display_filter_edit.cpp | 283 ++++-- ui/qt/display_filter_edit.h | 19 +- ui/qt/filter_dialog.cpp | 11 +- ui/qt/filter_dialog.h | 4 +- ui/qt/main_window.cpp | 3 +- ui/qt/main_window.h | 1 - ui/qt/main_window_slots.cpp | 27 - ui/qt/preferences_dialog.ui | 2 +- ui/qt/stock_icon.cpp | 22 +- ui/qt/stock_icon.h | 2 +- ui/qt/wireshark_application.cpp | 1 - 77 files changed, 2107 insertions(+), 1064 deletions(-) delete mode 100644 image/dfilter_apply_disabled.png delete mode 100644 image/dfilter_apply_hover.png delete mode 100644 image/dfilter_apply_normal.png delete mode 100644 image/dfilter_apply_pressed.png delete mode 100644 image/dfilter_bookmark_disabled.png delete mode 100644 image/dfilter_bookmark_hover.png delete mode 100644 image/dfilter_bookmark_normal.png delete mode 100644 image/dfilter_bookmark_pressed.png delete mode 100644 image/dfilter_dropdown.png delete mode 100644 image/dfilter_erase_active.png delete mode 100644 image/dfilter_erase_normal.png delete mode 100644 image/dfilter_erase_selected.png delete mode 100644 image/dfilter_refresh_active.png delete mode 100644 image/dfilter_refresh_normal.png delete mode 100644 image/display_filter.qrc create mode 100644 image/toolbar/14x14/x-filter-bookmark.active.png create mode 100644 image/toolbar/14x14/x-filter-bookmark.active.svg ... 41 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 4f5937a: Qt: Fixed a QString memory leak
- Next by Date: [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64
- Previous by thread: [Wireshark-commits] master 4f5937a: Qt: Fixed a QString memory leak
- Next by thread: [Wireshark-commits] master 5b468c4: Reflect the removal of some display filter-related images.
- Index(es):