Wireshark · Wireshark-commits: [Wireshark-commits] master 0badc8c: Insure Qt Capture preferences dialog displays default capture de

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0badc8c38e56e60bdd5d4fd95f78486234067a16
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0badc8c by Jim Young (jyoung@xxxxxxx):

    Insure Qt Capture preferences dialog displays default capture device (if any)
    
    In CapturePreferencesFrame::updateWidgets() save and restore the default
    capture device name because the first call (and only the first call) in
    the loop with addItem() triggers on_defaultInterfaceComboBox_editTextChanged()
    which unconditionally sets the default name as the first non-hidden device.
    
    Bug: 10965
    Change-Id: Ie93f84010a19e8144efa46ce889fb9064979e0e9
    Reviewed-on: https://code.wireshark.org/review/9584
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  51e77b6   CBOR: fix no previous prototype for proto_reg*_cbor [-Wmissing-prototypes]
    adds  0badc8c   Insure Qt Capture preferences dialog displays default capture device (if any)


Summary of changes:
 ui/qt/capture_preferences_frame.cpp |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)