Wireshark-commits: [Wireshark-commits] master-1.12 f1c7cad: Make bit masks unsigned.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Aug 2015 12:30:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1c7cad16985ccb24ccf0510e47826bdea21c8e4
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f1c7cad by Guy Harris (guy@xxxxxxxxxxxx):

    Make bit masks unsigned.
    
    To quote a run-time error reported in
    
    	https://www.wireshark.org/lists/wireshark-dev/201504/msg00084.html
    
    "left shift of 1 by 31 places cannot be represented in type 'int'", so
    use type "unsigned int" instead, by shifting 1U rather than 1 left.
    
    Change-Id: I95cf5ce53aa3b94ccb9f246d31863715bb682409
    Reviewed-on: https://code.wireshark.org/review/8252
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f80205e32fd0d6b0f1003cdebcbcddbac9cfb9b7)
    Reviewed-on: https://code.wireshark.org/review/10277
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b19b729   Explain why the MSDU length field in an A-MSDU is big-endian.
    adds  f1c7cad   Make bit masks unsigned.


Summary of changes:
 epan/proto.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)