Wireshark-commits: [Wireshark-commits] master 5a7f574: Fix two bugs 1) Introduced by me in commit c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Aug 2015 12:21:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a7f574cbd2af2f271df1a94e682ade7fa607ef9
Submitter: Jörg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5a7f574 by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix two bugs
      1) Introduced by me in commit c4fe7129d802752aa4cc89a66d2d5d5f2698e020
         where I didn't honor the "print lsa header only" flag properly for
         data highlighting
      2) Introduced in 2001 with commit dd1b7eafafb5748757a0396f4cc6ad6e65f37483
         which moved offset increasing into an "if (tree)" statement with code
         after the if statement continuing to work with offset.
    Also make display of v2 and v3 LSAs the same again (forgot one case in
    previous commit.
    
    bug:11461
    Change-Id: I1986c19842f1fa9c8a6d0a7c9a79c64939eeb9d0
    Reviewed-on: https://code.wireshark.org/review/10192
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  b0a8fa5   Initialize extcap for pipes
    adds  5a7f574   Fix two bugs   1) Introduced by me in commit c4fe7129d802752aa4cc89a66d2d5d5f2698e020      where I didn't honor the "print lsa header only" flag properly for      data highlighting   2) Introduced in 2001 with commit dd1b7eafafb5748757a0396f4cc6ad6e65f37483      which moved offset increasing into an "if (tree)" statement with code      after the if statement continuing to work with offset. Also make display of v2 and v3 LSAs the same again (forgot one case in previous commit.


Summary of changes:
 epan/dissectors/packet-ospf.c |   37 +++++++++++++++++++------------------
 1 file changed, 19 insertions(+), 18 deletions(-)